Add DataValidity property
#486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## diagnostic_report_updates #486 +/- ##
=============================================================
+ Coverage 77.83% 78.23% +0.39%
=============================================================
Files 100 102 +2
Lines 3574 3625 +51
=============================================================
+ Hits 2782 2836 +54
+ Misses 792 789 -3
☔ View full report in Codecov by Sentry. |
frances-h
reviewed
Oct 30, 2023
rwedge
reviewed
Oct 30, 2023
Comment on lines
46
to
47
| primary_key_match = column_name == metadata.get('primary_key') | ||
| alternate_key_match = column_name in metadata.get('alternate_keys', []) |
There was a problem hiding this comment.
we could get the primary and alternate keys outside of the loop and store as variables
There was a problem hiding this comment.
Yes, done in fe4d1f4
R-Palazzo
force-pushed
the
issue-467-data-validity-property
branch
from
fe4d1f4 to
5776ad8
Compare
R-Palazzo
force-pushed
the
issue-467-data-validity-property
branch
from
5776ad8 to
58cb42b
Compare
frances-h
approved these changes
Nov 2, 2023
rwedge
approved these changes
Nov 2, 2023
R-Palazzo
added a commit
that referenced
this pull request
Nov 2, 2023
R-Palazzo
added a commit
that referenced
this pull request
Nov 6, 2023
R-Palazzo
added a commit
that referenced
this pull request
Nov 14, 2023
R-Palazzo
added a commit
that referenced
this pull request
Nov 27, 2023
R-Palazzo
added a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86ayg9qx7
Resolve #467
The visualization is:
@frances-h, @npatki