Make quality reports fault tolerant on missing relationships in metadata #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
- Coverage 77.07% 77.02% -0.06%
==========================================
Files 93 93
Lines 3416 3425 +9
==========================================
+ Hits 2633 2638 +5
- Misses 783 787 +4
☔ View full report in Codecov by Sentry. |
npatki
approved these changes
Nov 1, 2023
amontanez24
reviewed
Nov 1, 2023
sdmetrics/reports/multi_table/_properties/inter_table_trends.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86ayjkavn
#86ayjkavn
resolves #481
Missing relationship metadata no longer throws an error but instead returns NaN for the score report for multitable data.