Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple FutureWarning lines printed out when running the Quality Report (Intertable Trends property) #491

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Multiple FutureWarning lines printed out when running the Quality Report (Intertable Trends property) #491

merged 2 commits into from
Nov 1, 2023

Conversation

frances-h
Copy link
Contributor

Resolve #490

@frances-h frances-h self-assigned this Nov 1, 2023
@frances-h frances-h requested a review from a team as a code owner November 1, 2023 15:11
@frances-h frances-h requested review from lajohn4747 and amontanez24 and removed request for a team November 1, 2023 15:11
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82c9c65) 77.04% compared to head (1ed2d76) 77.04%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #491   +/-   ##
=======================================
  Coverage   77.04%   77.04%           
=======================================
  Files          93       93           
  Lines        3419     3419           
=======================================
  Hits         2634     2634           
  Misses        785      785
Files Coverage Δ
...orts/multi_table/_properties/inter_table_trends.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amontanez24
amontanez24 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frances-h frances-h merged commit 8815855 into main Nov 1, 2023
90 checks passed
@frances-h frances-h deleted the issue-490-intertabletrends-future-warning branch November 1, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lajohn4747 lajohn4747 lajohn4747 approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees

@frances-h frances-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple FutureWarning lines printed out when running the Quality Report (Intertable Trends property)
4 participants
@frances-h @codecov-commenter @amontanez24 @lajohn4747