Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ContingencySimilarity metric should be able to discretize continuous columns #702

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

frances-h
Copy link
Contributor

Resolve #700
CU-86b3a8dy8

@sdv-team
Copy link
Contributor

sdv-team commented Jan 6, 2025

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (b83bcf9) to head (6e5a57f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
+ Coverage   94.44%   94.47%   +0.03%     
==========================================
  Files         106      106              
  Lines        4103     4126      +23     
==========================================
+ Hits         3875     3898      +23     
  Misses        228      228              
Flag Coverage Δ
integration 78.25% <48.14%> (-0.15%) ⬇️
unit 81.82% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frances-h frances-h marked this pull request as ready for review January 7, 2025 14:38
@frances-h frances-h force-pushed the issue-700-discretize-ContingenceSimilarity branch from 6e5a57f to ee1eee0 Compare January 9, 2025 16:02
@frances-h frances-h merged commit 799c4ad into main Jan 9, 2025
47 checks passed
@frances-h frances-h deleted the issue-700-discretize-ContingenceSimilarity branch January 9, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ContingencySimilarity metric should be able to discretize continuous columns
4 participants