Add Range CAG #2407
Open
Add Range CAG #2407
+1,596
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-86b424066 SDV - Add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## issue-2384-inquality-cags #2407 +/- ##
=============================================================
+ Coverage 98.56% 98.59% +0.03%
=============================================================
Files 66 67 +1
Lines 6563 6710 +147
=============================================================
+ Hits 6469 6616 +147
Misses 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fealho
requested review from
amontanez24 and
gsheni
and removed request for
frances-h
fealho
force-pushed
the
issue-2385-range-pattern
branch
2 times, most recently
from
2e22061 to
822bcb9
Compare
gsheni
reviewed
Mar 7, 2025
gsheni
approved these changes
Mar 7, 2025
R-Palazzo
reviewed
Mar 10, 2025
Comment on lines
+100
to
+101
| # Set during transform | ||
| self._nan_column_name = None |
There was a problem hiding this comment.
Could we set this during fit() as well?
fealho
force-pushed
the
issue-2384-inquality-cags
branch
from
fd4882b to
f9d68b7
Compare
fealho
force-pushed
the
issue-2385-range-pattern
branch
from
8251041 to
b424d6f
Compare
amontanez24
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b424066, Resolve #2385.