-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AddressBook: remove unused containsTag()
AddressBook#containsTag() checks if a given Tag is in the master list of Tags. This method is not used anywhere, and can be classified as unused code. There are no commands that support it, and it is also not part of any learning objectives. While it is used in two tests for AddressBook#addPerson(), it should be replaced with the existing AddressBookTest#isTagObjectInAddressBookList() to improve code reuse. AddressBook#containsTag() should be removed as unused code contributes to maintenance and comprehension overheads. Let's remove AddressBook#containsTag().
- Loading branch information
1 parent
aa54170
commit a5ed663
Showing
2 changed files
with
3 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters