-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a BC file extension for Architecture, a bare-bones MDReport, an ArchitectureAnalysis experiment and "SynthSAWholeProgram" as a project #878
base: vara-dev
Are you sure you want to change the base?
Conversation
varats/varats/experiments/vara/architecture_report_experiment.py
Outdated
Show resolved
Hide resolved
varats/varats/experiments/vara/architecture_report_experiment.py
Outdated
Show resolved
Hide resolved
varats/varats/experiments/vara/architecture_report_experiment.py
Outdated
Show resolved
Hide resolved
opt_params = [ | ||
"-O0", "-g0", "-fvara-GB", | ||
"-S", "-fvara-arch", | ||
f"-vara-report-outfile={result_file}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mixed two things here: clang options and opt options.
In this analysis step, you want to produce a report by running a certain VaRA analysis.
This works similar to the BlameReportGeneration
step and requires opt
.
The flags "-O0", "-g0", "-fvara-GB", "-fvara-arch"
are all compiler flags which have to be passed to clang
.
You have to set them before you add the Compile
step (see comment below).
As far as opt
parameters go, you have to pass --enable-new-pm=0
, f"-vara-report-outfile={result_file}"
and an option that enables the analysis pass. However, you have to implement that pass on the VaRA side first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we already discussed how to go about implementing the pass on VaRA’s side? Or shall I look into this myself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have briefly talked about how that works in general, but no details yet.
You can take a look at existing passes to figure out how a pass for creating an ArchitectureReport
could look like, e.g., BlameReportCreatorPass
in vara/Report/BlameReport.h
.
varats/varats/experiments/vara/architecture_report_experiment.py
Outdated
Show resolved
Hide resolved
varats/varats/experiments/vara/architecture_report_experiment.py
Outdated
Show resolved
Hide resolved
"-O0", "-g0", "-fvara-GB", | ||
"-S", "-fvara-arch", | ||
f"-vara-report-outfile={result_file}", | ||
get_cached_bc_file_path( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import this from wllvm.py
. Same goes for the BCFileExtensions
.
…a project" This reverts commit 2e3571e.
… test "test_bb_config.py"
No description provided.