Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a BC file extension for Architecture, a bare-bones MDReport, an ArchitectureAnalysis experiment and "SynthSAWholeProgram" as a project #878

Draft
wants to merge 10 commits into
base: vara-dev
Choose a base branch
from

Conversation

s8jsweis
Copy link

No description provided.

@s8jsweis s8jsweis requested a review from boehmseb March 18, 2024 12:56
varats-core/varats/experiment/wllvm.py Outdated Show resolved Hide resolved
Comment on lines 53 to 56
opt_params = [
"-O0", "-g0", "-fvara-GB",
"-S", "-fvara-arch",
f"-vara-report-outfile={result_file}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mixed two things here: clang options and opt options.
In this analysis step, you want to produce a report by running a certain VaRA analysis.
This works similar to the BlameReportGeneration step and requires opt.
The flags "-O0", "-g0", "-fvara-GB", "-fvara-arch" are all compiler flags which have to be passed to clang.
You have to set them before you add the Compile step (see comment below).

As far as opt parameters go, you have to pass --enable-new-pm=0, f"-vara-report-outfile={result_file}" and an option that enables the analysis pass. However, you have to implement that pass on the VaRA side first.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we already discussed how to go about implementing the pass on VaRA’s side? Or shall I look into this myself?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have briefly talked about how that works in general, but no details yet.
You can take a look at existing passes to figure out how a pass for creating an ArchitectureReport could look like, e.g., BlameReportCreatorPass in vara/Report/BlameReport.h.

"-O0", "-g0", "-fvara-GB",
"-S", "-fvara-arch",
f"-vara-report-outfile={result_file}",
get_cached_bc_file_path(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import this from wllvm.py. Same goes for the BCFileExtensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants