Skip to content

Commit

Permalink
Merge branch '214-update-to-nodejs-v18' into 'master'
Browse files Browse the repository at this point in the history
Resolve "Update to NodeJS v18"

Closes #214

See merge request se2/whisker/whisker-main!371
  • Loading branch information
schweikl committed Oct 7, 2023
2 parents 50edcef + c155458 commit b03d9ea
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
image: satantime/puppeteer-node:16.14.0-bullseye
image: satantime/puppeteer-node:18.18.0-bullseye

stages:
- build
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.14.0
18.18.0
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
# [1] https://www.ibm.com/docs/en/filenet-p8-platform/5.5.x?topic=deployment-choosing-image-tags-digests
# [2] https://hub.docker.com/_/node?tab=tags
#
# Currently, this digest corresponds to the tag 16.14.0-bullseye-slim:
# https://hub.docker.com/layers/satantime/puppeteer-node/16.14.0-bullseye-slim/images/sha256-bed240a3b8cd99af56a2971046201a26fba978804f55c296bde7f9b1075d19bc?context=explore
ARG version=@sha256:bed240a3b8cd99af56a2971046201a26fba978804f55c296bde7f9b1075d19bc
# Currently, this digest corresponds to the tag 18.18.0-bullseye-slim:
# https://hub.docker.com/layers/satantime/puppeteer-node/18.18-bullseye-slim/images/sha256-0a94786a0cd3ba9f43a85caabc1d6ae31143c600be0e68027ff19f1c0b7e9555?context=explore
ARG version=@sha256:0a94786a0cd3ba9f43a85caabc1d6ae31143c600be0e68027ff19f1c0b7e9555

# (a) We use a slim base image that already includes Node.JS and a minimal set
# of packages required to run Puppeteer (without packaging Puppeteer
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Whisker provides automated and property-based testing functionality for Scratch

## Building Whisker

Whisker requires Node.js v16.14.0 and is built using the [yarn](https://classic.yarnpkg.com/lang/en/) (classic) package manager.
Whisker requires Node.js v18.18.0 and is built using the [yarn](https://classic.yarnpkg.com/lang/en/) (classic) package manager.

After cloning the repository, install all dependencies using:

Expand Down

0 comments on commit b03d9ea

Please sign in to comment.