-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elfloader,RISC-V: Fix early boot issues #136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #84 |
This was referenced Feb 4, 2022
kent-mcleod
force-pushed
the
kent/patch34
branch
2 times, most recently
from
February 4, 2022 06:24
896d595
to
bf06416
Compare
Thanks for separating that out, much easier to review. |
axel-h
reviewed
Feb 4, 2022
axel-h
reviewed
Feb 4, 2022
lsf37
added a commit
to seL4/ci-actions
that referenced
this pull request
Feb 4, 2022
This failure is an elfloader problem, to be fixed in seL4/seL4_tools#136 Signed-off-by: Gerwin Klein <[email protected]>
kent-mcleod
force-pushed
the
kent/patch34
branch
from
February 4, 2022 11:16
54f8edc
to
57eca75
Compare
axel-h
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me to be merged
lsf37
reviewed
Feb 4, 2022
lsf37
approved these changes
Feb 4, 2022
Good to merge? |
- Set a valid stack before calling any C function so that memory and registers don't get corrupted. - Keep track of the DTB address so that it's still in a1 when main is called even if we needed to switch to a different HART. - If the HSM extention isn't present, then try and call main on the current HART. - Suspend HARTs that exceed CONFIG_MAX_NUM_NODES. Signed-off-by: Kent McLeod <[email protected]>
kent-mcleod
force-pushed
the
kent/patch34
branch
from
February 6, 2022 01:58
c5348d3
to
282ac20
Compare
lsf37
added a commit
to seL4/ci-actions
that referenced
this pull request
Feb 6, 2022
This failure is an elfloader problem, to be fixed in seL4/seL4_tools#136 Signed-off-by: Gerwin Klein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registers don't get corrupted.
called even if we needed to switch to a different HART.
current HART.
Signed-off-by: Kent McLeod [email protected]