Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libplatsupport: use proper format specifier #180

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Feb 28, 2024

This avoid a build warning with clang, which can also be found in CI (see e.g. https://github.com/seL4/seL4/actions/runs/8085439570/job/22092970792)

  [78/256] Building C object apps/sel4test-driver/util_libs/libplatsupport/CMakeFiles/platsupport.dir/src/plat/hifive/ltimer.c.obj
  /github/workspace/projects/util_libs/libplatsupport/src/plat/hifive/ltimer.c:104:55: warning: format specifies type 'int' but the argument has type 'long' [-Wformat]
          ZF_LOGE("Invalid IRQ number: %d received.\n", irq_number);
                                       ~~               ^~~~~~~~~~
                                       %ld
  /github/workspace/projects/util_libs/libutils/include/utils/zf_log.h:359:43: note: expanded from macro 'ZF_LOGE'
                          _ZF_LOG_IMP(ZF_LOG_ERROR, _ZF_LOG_TAG, __VA_ARGS__)
                                                                 ^~~~~~~~~~~
  /github/workspace/projects/util_libs/libutils/include/utils/zf_log.h:302:18: note: expanded from macro '_ZF_LOG_IMP'
                                                          lvl, tag, __VA_ARGS__); \
                                                                    ^~~~~~~~~~~

@axel-h axel-h added the hw-build all sel4test hardware builds label Feb 28, 2024
@axel-h axel-h requested a review from Indanz February 29, 2024 13:17
@Indanz Indanz merged commit 1b55577 into seL4:master Mar 2, 2024
30 checks passed
@axel-h axel-h deleted the patch-axel-20 branch March 4, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hw-build all sel4test hardware builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants