Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: add shell check github actions to basefs #15

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

allencloud
Copy link
Member

Signed-off-by: Allen Sun [email protected]

Describe what this PR does / why we need it

add shell check github actions to basefs for all shell files.

Does this pull request fix one issue?

none

Describe how you did it

none

Describe how to verify it

none

Special notes for reviews

none

@allencloud
Copy link
Member Author

After the first commit, there are following issues:

Warning: ./auto-build.sh:57:5: warning: This pattern always overrides a later one on line 57. [SC2221]
Warning: ./auto-build.sh:57:8: warning: This pattern never matches because of a previous pattern on line 57. [SC2222]
Warning: ./auto-build.sh:68:114: warning: Quote this to prevent word splitting. [SC2046]
Notice: ./auto-build.sh:107:8: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./auto-build.sh:108:8: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./auto-build.sh:109:16: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/rootfs/scripts/init-kube.sh:27:17: note: Not following: /etc/os-release was not specified as input (see shellcheck -x). [SC1091]
Notice: ./context/docker/rootfs/scripts/docker.sh:27:20: note: Not following: /etc/os-release was not specified as input (see shellcheck -x). [SC1091]
Notice: ./context/docker/rootfs/scripts/docker.sh:51:10: note: Double quote to prevent globbing and word splitting. [SC2086]
Warning: ./context/docker/rootfs/scripts/docker.sh:57:35: warning: This pattern always overrides a later one on line 60. [SC2221]
Warning: ./context/docker/rootfs/scripts/docker.sh:60:24: warning: This pattern never matches because of a previous pattern on line 57. [SC2222]
Warning: ./context/docker/rootfs/scripts/init-registry.sh:20:4: warning: Quote this to prevent word splitting. [SC2046]
Warning: ./context/docker/rootfs/scripts/init-registry.sh:22:1: warning: REGISTRY_PORT appears unused. Verify use (or export if used externally). [SC2034]
Warning: ./context/docker/rootfs/scripts/init-registry.sh:39:37: warning: This only exits the subshell caused by the (..) group. [SC2106]
Notice: ./context/docker/rootfs/scripts/init-registry.sh:75:9: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/docker/rootfs/scripts/init-registry.sh:76:26: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/docker/rootfs/scripts/init-registry.sh:81:9: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/docker/rootfs/scripts/init-registry.sh:82:16: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/docker/rootfs/scripts/init-registry.sh:83:16: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/docker/rootfs/scripts/init-registry.sh:88:16: note: Double quote to prevent globbing and word splitting. [SC2086]
Warning: ./context/containerd/rootfs/scripts/containerd.sh:19:6: warning: Quote this to prevent word splitting. [SC2046]
Warning: ./context/containerd/rootfs/scripts/init-registry.sh:20:4: warning: Quote this to prevent word splitting. [SC2046]
Warning: ./context/containerd/rootfs/scripts/init-registry.sh:22:1: warning: REGISTRY_PORT appears unused. Verify use (or export if used externally). [SC2034]
Warning: ./context/containerd/rootfs/scripts/init-registry.sh:39:38: warning: This only exits the subshell caused by the (..) group. [SC2106]
Warning: ./context/containerd/rootfs/scripts/init-registry.sh:51:58: warning: registry_status is referenced but not assigned. [SC2[154](https://github.com/sealerio/basefs/runs/6878331728?check_suite_focus=true#step:3:163)]
Notice: ./context/containerd/rootfs/scripts/init-registry.sh:73:9: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/containerd/rootfs/scripts/init-registry.sh:74:26: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/containerd/rootfs/scripts/init-registry.sh:79:9: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/containerd/rootfs/scripts/init-registry.sh:80:17: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/containerd/rootfs/scripts/init-registry.sh:81:16: note: Double quote to prevent globbing and word splitting. [SC2086]
Notice: ./context/containerd/rootfs/scripts/init-registry.sh:86:17: note: Double quote to prevent globbing and word splitting. [SC2086]

Will be updated soon

@allencloud allencloud force-pushed the add-shellcheck branch 3 times, most recently from 7935df9 to a3289c5 Compare June 20, 2022 12:24
@allencloud
Copy link
Member Author

allencloud commented Jun 20, 2022

@bxy4543 I have updated all the failing cases. Please help to review this again. Thanks a lot.

@allencloud allencloud merged commit 9ac97ea into sealerio:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants