Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry expose the metrics port #32

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

DawnGuoDev
Copy link

Describe what this PR does / why we need it

Registry will expose the metrics port. Users can get metrics from the port. It will not affect the use of registry.

Does this pull request fix one issue?

No.

Describe how you did it

Add some envs.

Describe how to verify it

curl http://${registryIP}:5001/metrics

Special notes for reviews

@DawnGuoDev DawnGuoDev force-pushed the feat/add-registry-metrics branch from d5b4d34 to c5c1a95 Compare November 22, 2022 12:56
@DawnGuoDev DawnGuoDev force-pushed the feat/add-registry-metrics branch from c5c1a95 to d248610 Compare November 22, 2022 12:57
Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit 6551e8c into sealerio:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants