fix: Use POST for all endpoints with params (#44)

* Ensure post is used for all endpoints with parameters * ci: Generate code --------- Co-authored-by: Seam Bot <[email protected]>
seamapi · Jan 22, 2024 · 97f20b3 · 97f20b3
1 parent 41b56a0
commit 97f20b3
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 43 deletions.
diff --git a/generate-routes.ts b/generate-routes.ts
@@ -217,8 +217,11 @@ const deriveResourceFromSchema = (properties: object): string | null =>
   Object.keys(properties).filter((key) => key !== 'ok')[0] ?? null
 
 const deriveSemanticMethod = (methods: string[]): Method => {
-  if (methods.includes('get')) return 'GET'
+  // UPSTREAM: This should return GET before POST.
+  // Blocked on https://github.com/seamapi/nextlove/issues/117
+  // and https://github.com/seamapi/javascript-http/issues/43
   if (methods.includes('post')) return 'POST'
+  if (methods.includes('get')) return 'GET'
   throw new Error(`Could not find valid method in ${methods.join(', ')}`)
 }
 
@@ -458,7 +461,9 @@ const renderRequestType = ({
     pascalCase(requestFormatToRequestType(name, namespace)),
   ].join('')
 
-// UPSTREAM: Should be just requestFormat, but blocked on https://github.com/seamapi/nextlove/issues/117
+// UPSTREAM: This function is a workaround, as the request type should always match the request format.
+// Blocked on https://github.com/seamapi/nextlove/issues/117
+// and https://github.com/seamapi/javascript-http/issues/43
 const requestFormatToRequestType = (
   name: string,
   _namespace: string,

diff --git a/src/lib/seam/connect/routes/connected-accounts.ts b/src/lib/seam/connect/routes/connected-accounts.ts
diff --git a/src/lib/seam/connect/routes/user-identities.ts b/src/lib/seam/connect/routes/user-identities.ts
diff --git a/src/lib/seam/connect/routes/webhooks.ts b/src/lib/seam/connect/routes/webhooks.ts
diff --git a/src/lib/seam/connect/routes/workspaces.ts b/src/lib/seam/connect/routes/workspaces.ts