Move waitForActionAttempt options into object

README.md

@@ -185,11 +185,15 @@ const [lock] = await seam.locks.list()
 if (lock == null) throw new Error('No locks in this workspace')
 
 try {
-  await seam.locks.unlockDoor({ device_id: lock.device_id, }, {
-    waitForActionAttempt: true
-    pollingInterval: 1000,
-    timeout: 5000,
-  })
+  await seam.locks.unlockDoor(
+    { device_id: lock.device_id },
+    {
+      waitForActionAttempt: {
+        pollingInterval: 1000,
+        timeout: 5000,
+      },
+    },
+  )
   console.log('Door unlocked')
 } catch (err: unknown) {
   if (isSeamActionAttemptFailedError(err)) {

generate-routes.ts

@@ -342,7 +342,13 @@ const renderClassMethod = ({
     })
     ${
       resource === 'action_attempt'
-        ? `if (waitForActionAttempt) { return resolveActionAttempt(data.${resource}, SeamHttpActionAttempts.fromClient(this.client), { timeout, pollingInterval }) }`
+        ? `if (waitForActionAttempt != null && waitForActionAttempt !== false) {
+            return resolveActionAttempt(
+              data.${resource},
+              SeamHttpActionAttempts.fromClient(this.client),
+              typeof waitForActionAttempt === 'boolean' ? {} : waitForActionAttempt,
+            )
+          }`
         : ''
     }
     ${resource === null ? '' : `return data.${resource}`}
@@ -353,7 +359,7 @@ const renderClassMethodOptions = ({
   resource,
 }: Pick<Endpoint, 'resource'>): string => {
   if (resource === 'action_attempt') {
-    return `{ waitForActionAttempt = false, timeout = 5000, pollingInterval = 500 }: ${renderClassMethodOptionsTypeDef(
+    return `{ waitForActionAttempt = false }: ${renderClassMethodOptionsTypeDef(
       { resource },
     )} = {},`
   }
@@ -371,8 +377,8 @@ const renderClassMethodOptionsTypeDef = ({
 }: Pick<Endpoint, 'resource'>): string => {
   if (resource === 'action_attempt') {
     return `
-      Partial<ResolveActionAttemptOptions> & {
-        waitForActionAttempt?: boolean
+      {
+        waitForActionAttempt?: boolean | Partial<ResolveActionAttemptOptions>
       }
     `
   }

src/lib/seam/connect/resolve-action-attempt.ts

@@ -6,14 +6,14 @@ import type {
 import type { SeamHttpActionAttempts } from './routes/index.js'
 
 export interface ResolveActionAttemptOptions {
-  timeout: number
-  pollingInterval: number
+  timeout?: number
+  pollingInterval?: number
 }
 
 export const resolveActionAttempt = async <T extends ActionAttempt>(
   actionAttempt: T,
   actionAttempts: SeamHttpActionAttempts,
-  { timeout, pollingInterval }: ResolveActionAttemptOptions,
+  { timeout = 5000, pollingInterval = 500 }: ResolveActionAttemptOptions,
 ): Promise<SuccessfulActionAttempt<T>> => {
   let timeoutRef
   const timeoutPromise = new Promise<SuccessfulActionAttempt<T>>(

test/seam/connect/wait-for-action-attempt.test.ts

@@ -107,8 +107,9 @@ test('waitForActionAttempt: times out while waiting for action attempt', async (
           action_attempt_id: actionAttempt.action_attempt_id,
         },
         {
-          waitForActionAttempt: true,
-          timeout: 100,
+          waitForActionAttempt: {
+            timeout: 100,
+          },
         },
       ),
     { instanceOf: SeamActionAttemptTimeoutError },
@@ -182,9 +183,10 @@ test('waitForActionAttempt: times out if waiting for polling interval', async (t
           action_attempt_id: actionAttempt.action_attempt_id,
         },
         {
-          waitForActionAttempt: true,
-          timeout: 500,
-          pollingInterval: 10_000,
+          waitForActionAttempt: {
+            timeout: 500,
+            pollingInterval: 10_000,
+          },
         },
       ),
     { instanceOf: SeamActionAttemptTimeoutError },