Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Test other auth methods against fake-seam-connect #150

Merged
merged 16 commits into from
Dec 17, 2024
Merged

Conversation

razor-x
Copy link
Member

@razor-x razor-x commented Aug 5, 2024

Trying to use the changes introduced in seamapi/fake-seam-connect#200 (comment)

@razor-x
Copy link
Member Author

razor-x commented Aug 30, 2024

@andrii-balitskyi This is low priority, but if you feel like working out this puzzle, it would be nice to find the bug in fake-seam-connect and get the tests passing.

Basically, this PR was merged, but something is not implemented right there: seamapi/fake-seam-connect#200 (comment)

A good start would be adding a test to fake-seam-connect that reproduced the errors in this PR.

test/seam/connect/console-session-token.test.ts Dismissed Show dismissed Hide dismissed
test/seam/connect/console-session-token.test.ts Dismissed Show dismissed Hide dismissed
test/seam/connect/console-session-token.test.ts Dismissed Show dismissed Hide dismissed
test/seam/connect/console-session-token.test.ts Dismissed Show dismissed Hide dismissed
test/seam/connect/env.test.ts Dismissed Show dismissed Hide dismissed
@andrii-balitskyi
Copy link
Contributor

@razor-x with fake-seam-connect version 1.74.0 the tests are finally passing! :)

package.json Outdated Show resolved Hide resolved
@razor-x razor-x changed the title Test other auth methods against fake-seam-connect test: Test other auth methods against fake-seam-connect Dec 17, 2024
@razor-x razor-x marked this pull request as ready for review December 17, 2024 20:09
@razor-x razor-x requested a review from a team as a code owner December 17, 2024 20:09
@razor-x razor-x merged commit 5c7135b into main Dec 17, 2024
20 checks passed
@razor-x razor-x deleted the unskip-tests branch December 17, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants