-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SeamHttpRequest #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
razor-x
reviewed
Mar 25, 2024
razor-x
reviewed
Mar 25, 2024
I meant to mention this earlier, but we should add a section to https://github.com/seamapi/javascript-http?tab=readme-ov-file#advanced-usage Name could be "Inspecting the Request" |
razor-x
reviewed
Mar 26, 2024
phpnode
force-pushed
the
seam-api-request
branch
from
March 26, 2024 17:04
604bc41
to
9633c14
Compare
razor-x
reviewed
Mar 26, 2024
razor-x
reviewed
Mar 26, 2024
razor-x
reviewed
Mar 26, 2024
Co-authored-by: Evan Sosenko <[email protected]>
razor-x
reviewed
Mar 26, 2024
Co-authored-by: Evan Sosenko <[email protected]>
Co-authored-by: Charles Pick <[email protected]>
Support for SeamHttpRequest url param
razor-x
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often useful to be able to inspect an API Request before it is sent. This PR adds a new class,
SeamHttpRequest
which implementsPromiseLike<T>
which holds some information about the request before it is sent to the server. The actual request to the server is made when theSeamHttpRequest
isawaited
.e.g.
Of course the request can be awaited immediately, as normal:
I'm not married to the naming here so please feel free to bikeshed it 😄