Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SeamHttpRequest implements Promise<T> rather than PromiseLike<T> #70

Merged
merged 4 commits into from
Mar 29, 2024
Merged

fix: SeamHttpRequest implements Promise<T> rather than PromiseLike<T> #70

merged 4 commits into from
Mar 29, 2024

Conversation

phpnode
Copy link
Contributor

@phpnode phpnode commented Mar 29, 2024

It's not sufficient to implement PromiseLike<T> when libraries such as react query expect T | Promise<T>

@phpnode phpnode requested a review from razor-x as a code owner March 29, 2024 00:25
razor-x
razor-x approved these changes Mar 29, 2024
View reviewed changes
src/lib/seam/connect/index.ts Show resolved Hide resolved
@phpnode phpnode merged commit 0cc2da2 into main Mar 29, 2024
15 checks passed
@phpnode phpnode deleted the seam-http-request-must-implement-promise branch March 29, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razor-x razor-x razor-x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phpnode @razor-x @seambot