feat(wasm): add support for the stable target wasm32-wasip2 #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2024
Signed-off-by: Brooks Townsend <[email protected]> refactor(wasm): add wasm mod Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/wasi-p2-component-stable-blocking
branch
from
1379d90 to
7edd47e
Compare
Signed-off-by: Brooks Townsend <[email protected]> cleanup extraneous comment Signed-off-by: Brooks Townsend <[email protected]> feat: give back incoming body too Signed-off-by: Brooks Townsend <[email protected]> deps(url): remove patch Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]> example cleanup extra blocking feature Signed-off-by: Brooks Townsend <[email protected]> use body example Signed-off-by: Brooks Townsend <[email protected]> deps(url): remove patch Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/wasi-p2-component-stable-blocking
branch
from
7edd47e to
3b3c99e
Compare
|
Apologies for letting this go stale here, I haven't had the time to really shore this one up. I think there's a lot of promise in this approach, and I also don't want to overindex on supporting I think in the shorter term what would make this PR a candidate for review and merging would either be:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2294
Depends on servo/rust-url#983This PR, in order of commits:
reqwestin the generalwasm32OS and thewasm32-wasip2target (which is now a tier 2 target and Rust stable in 1.82)wasm32-wasip2implementations forreqwestso that you can compile WebAssembly components and make outgoing requests that compile down towasi:httpbindings- This commit also adds a patch for crates.io that depends on fix: supportwasm32-wasip2on the stable channel servo/rust-url#983, which is why this PR is a draft. There is no significant functionality change upstream to make the wasm32-wasip2 target work for theurlcrate, just a change to remove an unstable feature flag.wasm_componentto illustrate how this crate can be used in the context of awasm32-wasip2program.I've attempted to bring over the minimal implementations into the wasm32-wasip2 code, e.g. no multipart support, to keep the review focused and simple to start. If any of these need to be added, I'm happy to add follow-up commits after the review.