docs: document using non-zero ports in resolved addresses #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
flub
reviewed
Nov 7, 2024
Nuhvi
force-pushed
the
docs/port-behavior
branch
from
5f7d40a to
aff4120
Compare
flub
approved these changes
Nov 7, 2024
|
Thanks for updating these docs! ❤️ |
Nuhvi
force-pushed
the
docs/port-behavior
branch
from
aff4120 to
7e9ab82
Compare
Nuhvi
force-pushed
the
docs/port-behavior
branch
from
7e9ab82 to
618db2a
Compare
seanmonstar
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation of handling port numbers in resolved socket addresses, after updating
hyper_utilincluding this PR hyperium/hyper-util#148At least 2 teams mentioned that the current outdated documentation confused them (apologies, that hyper_util was my PR).