arm64 compatibility #121
Merged
arm64 compatibility #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insatomcat
force-pushed
the
arm64
branch
10 times, most recently
from
3a4d454 to
439f47a
Compare
|
FWIW, I approve this PR |
ycongal-smile
added a commit
to ycongal-smile/fai
that referenced
this pull request
Dec 27, 2024
Leverage existing work in progress arm64 support to build a working ISO. NB: This work comes from the SEAPATH project: seapath/build_debian_iso#121 Co-authored-by: Florent CARLI <[email protected]> Signed-off-by: Yoann Congal <[email protected]>
ycongal-smile
added a commit
to ycongal-smile/fai-config
that referenced
this pull request
Dec 27, 2024
The "--target=x86_64-efi" option obviously does not work for arm64 installation. Skip it in case of an arm64 installation, the x86-64 default is unchanged. NB: This work comes from the SEAPATH project: seapath/build_debian_iso#121 Co-authored-by: Florent CARLI <[email protected]> Signed-off-by: Yoann Congal <[email protected]>
Signed-off-by: Florent CARLI <[email protected]>
ycongal-smile
added a commit
to ycongal-smile/fai
that referenced
this pull request
Dec 28, 2024
Leverage existing work in progress arm64 support to build a working ISO. NB: This work comes from the SEAPATH project: seapath/build_debian_iso#121 Co-authored-by: Florent CARLI <[email protected]> Signed-off-by: Yoann Congal <[email protected]>
Mrfai
pushed a commit
to faiproject/fai
that referenced
this pull request
Dec 29, 2024
Leverage existing work in progress arm64 support to build a working ISO. NB: This work comes from the SEAPATH project: seapath/build_debian_iso#121 Co-authored-by: Florent CARLI <[email protected]> Signed-off-by: Yoann Congal <[email protected]>
dupremathieu
approved these changes
Jan 6, 2025
Comment on lines
+158
to
+161
| echo \"patch /usr/sbin/fai-cd /etc/fai/fai-cd.patch -o /ext/fai-cd\" && \ | ||
| patch /usr/sbin/fai-cd /etc/fai/fai-cd.patch -o /ext/fai-cd && chmod 755 /ext/fai-cd && \ | ||
| echo \"patch /ext/srv/fai/config/scripts/GRUB_EFI/10-setup /etc/fai/10-setup.patch \" && \ | ||
| patch /ext/srv/fai/config/scripts/GRUB_EFI/10-setup /etc/fai/10-setup.patch && \ |
There was a problem hiding this comment.
These patches are integrated into FAI 6.2.4:
faiproject/fai@3df1203#diff-93467241211d3f9d253fb8ad341738fbda5e5d3ade4721326f2bba82525fbaeeR46
We might just need to wait a little that the package make its way into the Debian/FAI repos&mirrors.
As of now, the 6.2.4 package is
- not available from FAI repos https://fai-project.org/download/bookworm/
- but is available on Debian repos : https://deb.debian.org/debian/pool/main/f/fai/fai-server_6.2.4_all.deb (sid)
See status in : https://tracker.debian.org/pkg/fai
There was a problem hiding this comment.
We don't use the debian package because the stable version is outdated (6.0.3).
I'll merge the change now, and I will do a new PR when 6.2.4 is the default in the FAI repo.
There was a problem hiding this comment.
You'll notice this quite easily, the patch will fail to apply and the process will fail :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.