Disable default white-label error pages #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended to override `BasicErrorController`. This controller only returns the status code, as opposed to the HTML which is the default error controller behaviour. To prevent confusion that may stem from manually navigating to `/api/error`, the route is instructed to return a 404 not found. In case of other errors, the appropriate status code will be returned instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning the default HTML, which is inconsistent with the site's style, we should just return the HTTP status code. API routes are not meant to be consumed through the browser anyway, so we should not care about how the browser renders the responses.
This also fixes a minor issue that would surface whenever the API redirected to
/error. The default view engine set up to serve these HTML files would complain about circular references. However, since we no longer render any HTML, the error has been removed.