allow me to not care in the slightest about these events #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a loop going that sometimes takes quite a while (https://github.com/hubblestack/hubble/blob/develop/hubblestack/extmods/modules/pulsar.py#L726). Occasionally, if the loop takes too long or something happens externally during the loop, some of the watches seem to disappear doing the
process_events(). I'm not totally sure what causes it. Is it the kernel canceling the watch and thereforeget_watch(raw_event.wd)is failing? are we externally modifying the watchlist during theprocess_events()? Not sure. What I can say is that it's always very shortly lived temp files that trigger this error.I'm confident the missing watches are safe to ignore. The 30,000 hosts reporting this error for /opt/specialthing/whatever is wasting quite a lot of space in our log analyzer. And we'd really rather keep watching the specialthing/whatever directory, even though it has quite a lot of tempfiles that pop in/out.
Let me know if you think this is a wrongheaded way to solve the problem or have a better idea what else we could fix.
Thanks.