Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pathlib objects, improve logging, fixes #187 #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fthiery
Copy link

@fthiery fthiery commented Jul 2, 2020

It would be good that pyinotify works with pathlib Path objects (see https://docs.python.org/3.8/library/pathlib.html); currently, the behaviour is that the path is silently dropped, which makes it quite hard to debug.

This MR suggests:

  • casting to string whenever possible (makes pathlib objects work)
  • adds a more explicit error when not possible to cast to string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant