Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix instancetype.int greater than 19 #106

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix instancetype.int greater than 19 #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a80de49
fix instancetype.integer issue with values greater 19
sebastian-toepfer Feb 13, 2024
401a3bc
bump version to 0.1.2
sebastian-toepfer Feb 13, 2024
3511540
Merge branch 'fix/integertype' into backmerge
sebastian-toepfer Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/io/github/sebastiantoepfer/jsonschema/InstanceType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private boolean isIntegral(final BigDecimal decimal) {
BigDecimal.ZERO.equals(decimal) ||
BigDecimal.ONE.equals(decimal) ||
BigDecimal.TEN.equals(decimal) ||
decimal.stripTrailingZeros().scale() == 0
decimal.stripTrailingZeros().scale() <= 0
);
}
},
Expand Down
3 changes: 3 additions & 0 deletions api/src/test/java/io/github/sebastiantoepfer/jsonschema/InstanceTypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ static Stream<? extends Arguments> provideWithValidCombinations() {
arguments(InstanceType.NUMBER, Json.createValue(23L)),
arguments(InstanceType.INTEGER, Json.createValue(23L)),
arguments(InstanceType.INTEGER, Json.createValue(10L)),
arguments(InstanceType.INTEGER, Json.createValue(20L)),
arguments(InstanceType.INTEGER, Json.createValue(100L)),
arguments(InstanceType.INTEGER, Json.createValue(1000L)),
arguments(InstanceType.INTEGER, Json.createValue(0.0))
);
}
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
</scm>

<properties>
<project.build.outputTimestamp>2024-01-18T19:42:58Z</project.build.outputTimestamp>
<project.build.outputTimestamp>2024-02-13T20:35:47Z</project.build.outputTimestamp>

<maven.compiler.source>17</maven.compiler.source>

Expand Down