Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RECOMMIT Left align enketo-notes-list labels #7

Open
wants to merge 2 commits into
base: places-survey
Choose a base branch
from

Conversation

sebastianbarry
Copy link
Owner

Redoing this commit from a separate branch

main.diary.css

  • Increased the left and right padding for .notes-list by 10px
  • Removed the place-items: center as it was overriding the left alignment
  • Added a new style called notes-list-label which aligns the text to the left

place_list_item.html

  • Removed the in-element styling for diary cards because this is now handled with the css

notes_list.html

  • The notes-list-label class is not being used by the notes-list label field to left align it

Redoing this commit from a separate branch

main.diary.css
- Increased the left and right padding for .notes-list by 10px
- Removed the place-items: center as it was overriding the left alignment
- Added a new style called notes-list-label which aligns the text to the left

place_list_item.html
- Removed the in-element styling for diary cards because this is now handled with the css

notes_list.html
- The notes-list-label class is not being used by the notes-list label field to left align it
enketo-notes-list.js
- Added $ionicPopup
- Added a new confirmDeleteEntry which first confirms you wish to delete, then calls the deleteEntry function

delete-entry.html
- Contains the template for the confirm delete popup

notes_list.html
- changed the trash can button to call confirmDeleteEntry() instead of going directly to deleteEntry(
@sebastianbarry
Copy link
Owner Author

Testing:

Part 1: Left justify entry labels
Simulator Screen Shot - iPhone 11 - 2023-03-17 at 16 10 55

Part 2: Confirm delete entry popup
https://user-images.githubusercontent.com/61334340/226062221-34999dea-69f1-422f-af9d-5e48ccb71265.mov

@sebastianbarry
Copy link
Owner Author

sebastianbarry commented Mar 17, 2023

@JGreenlee @shankari am I good to merge this with e-mission#919 places-survey?

@JGreenlee
Copy link
Collaborator

The vertical alignment changed a little bit as a consequence of the left alignment changing, but that's very minor and easy to tweak later

It seems fine to merge into places-survey whenever. it's not going to conflict with what I'm working on over there

@shankari
Copy link

@sebastianbarry you don't want to merge this to places-survey
You want to merge this to https://github.com/e-mission/e-mission-phone/tree/survey_refactor_expansion so that I can pull only these changes without pulling in all the other places changes (which don't work)

@shankari
Copy link

we can merge it into places-survey too later (along with my fixes - e.g. e-mission@683da75)
but for today, the goal is to merge into survey_refactor_expansion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants