-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RECOMMIT Left align enketo-notes-list labels #7
base: places-survey
Are you sure you want to change the base?
Conversation
Redoing this commit from a separate branch main.diary.css - Increased the left and right padding for .notes-list by 10px - Removed the place-items: center as it was overriding the left alignment - Added a new style called notes-list-label which aligns the text to the left place_list_item.html - Removed the in-element styling for diary cards because this is now handled with the css notes_list.html - The notes-list-label class is not being used by the notes-list label field to left align it
enketo-notes-list.js - Added $ionicPopup - Added a new confirmDeleteEntry which first confirms you wish to delete, then calls the deleteEntry function delete-entry.html - Contains the template for the confirm delete popup notes_list.html - changed the trash can button to call confirmDeleteEntry() instead of going directly to deleteEntry(
Testing:Part 1: Left justify entry labels Part 2: Confirm delete entry popup |
@JGreenlee @shankari am I good to merge this with e-mission#919 |
The vertical alignment changed a little bit as a consequence of the left alignment changing, but that's very minor and easy to tweak later It seems fine to merge into places-survey whenever. it's not going to conflict with what I'm working on over there |
@sebastianbarry you don't want to merge this to |
we can merge it into |
Redoing this commit from a separate branch
main.diary.css
place_list_item.html
notes_list.html