Add support for FTPS sync targets #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new property `\phpbu\App\Backup\Sync\Ftp::$secure` to support FTPS sync targets.
|
The failing PHPStan checks seem unrelated to the changes in this MR.. 🤔 |
|
Seems like OpenStack removed the class in the minor update from 3.5 to 3.6 yesterday 😀 |
sebastianfeldmann
approved these changes
Jan 18, 2024
sebastianfeldmann
approved these changes
Jan 18, 2024
sebastianfeldmann
merged commit 1646f41
into
sebastianfeldmann:main
0 of 4 checks passed
|
They fixed the BC in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our FTP hosters has recently moved to FTP via explicit SSL only, so I needed to add FTPS support to phpBU.
Thankfully, your FTP wrapper already supports this functionality (since v0.9.2, hence the updates to
composer.json), so I just added another optional boolean FTP config flag, similar to thepassiveflag.This should be fully backwards-compatible, as the FTP-lib already defaulted to
$secure = false.