Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arping() when route is missing #4567

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

gpotter2
Copy link
Member

  • minor fix of the arping() function to work when routes are missing

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (6f0faf3) to head (34e4085).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/l2.py 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4567      +/-   ##
==========================================
- Coverage   81.61%   81.60%   -0.02%     
==========================================
  Files         356      356              
  Lines       85545    85555      +10     
==========================================
- Hits        69819    69814       -5     
- Misses      15726    15741      +15     
Files with missing lines Coverage Δ
scapy/layers/l2.py 83.88% <41.66%> (-1.07%) ⬇️

... and 7 files with indirect coverage changes

@gpotter2 gpotter2 merged commit 014a86a into secdev:master Oct 14, 2024
23 of 24 checks passed
@gpotter2 gpotter2 deleted the mitm-fix branch October 14, 2024 19:01
@charles2910 charles2910 mentioned this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant