Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing new version #11

Merged
merged 71 commits into from
Jul 4, 2024
Merged

Preparing new version #11

merged 71 commits into from
Jul 4, 2024

Conversation

vincentadam87
Copy link
Collaborator

The current code

  • fixes the scipy dependency issues
  • removes unknown tag from pyproject.toml which prevented installation

thevincentadam and others added 30 commits September 8, 2021 12:03
@thevincentadam
first commit
70347df
@vincentadam87
wip
2f250cf
@vincentadam87
change python versions and poetry
67cfd46
@vincentadam87
change cmake version
760779e
@vincentadam87
change python version
0a99a56
@vincentadam87
change python version
1bcd32c
@vincentadam87
tf version for build
0547e27
@vincentadam87
tf version
76c5cce
@vincentadam87
tf version
1df5d4b
@vincentadam87
debugging with gpt
3a11b16
@vincentadam87
debugging with gpt v2
04f417e
@vincentadam87
debugging with gpt v3
d2c28f5
@vincentadam87
update mypy
98783c2
@vincentadam87
forgot the lock
d4feeab
@vincentadam87
black changes
c9e8add
@vincentadam87
versioning
e7997d0
@vincentadam87
update pyproject
804e0d0
@vincentadam87
ignore banded mypy
3de7817
@vincentadam87
temporary fix: skip test
9790b57
@vincentadam87
black
ccd3c82
@vincentadam87
putting header back
a93f64b
@vincentadam87
poetry task fix / rm setup.py / more python tested upon push
cd2740b
@vincentadam87
minor
45ed248
@vincentadam87
change tensorflow version range
17f2914
@vincentadam87
forgot the lock
99a6b31
@vincentadam87
changing tf version
dbcd088
@vincentadam87
update poetry
9c442e7
@vincentadam87
update worflow to force the lock to be regenerate
74e98be
@vincentadam87
update worflow to force the lock to be regenerate v2
0e86957
@vincentadam87
set matching python / tf
973048a
uri-granta
uri-granta reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the Version be updated in develop first?

awav
awav requested changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@awav awav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, address one my comment. Otherwise, LGTM.

pyproject.toml Outdated
@@ -91,4 +94,4 @@ line_length = 95
[build-system]
requires = ["poetry>=0.12", "cmake", "setuptools"] #, "tensorflow>=2.8.0,<2.9.0", "cmake"]
build-backend = "poetry.masonry.api"
flags = ["-DCMAKE_CXX_STANDARD=14"]
# flags = ["-DCMAKE_CXX_STANDARD=14"] (removing because flags not a recognized property)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be added to the list of cmake flags:

banded_matrices/build.py

Line 65 in 3a765fc

f"-DPYTHON_BIN={sys.executable}",
. I'm not quite sure how did it work before. Also, I would bump the standard to 17 or even 20 if possible.

@vincentadam87 vincentadam87 merged commit 8d6136a into master Jul 4, 2024
4 checks passed
@awav
Copy link
Collaborator

awav commented Jul 4, 2024

Also, @uri-granta was right about the version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-granta uri-granta uri-granta left review comments

@awav awav awav requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincentadam87 @awav @uri-granta @thevincentadam