Add processing of geometry models #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
minhnh
commented
Mar 5, 2025
•
minhnh
commented
- Process models as discussed in Migrating Coordinate Extensions from bdd-dsl metamodels#21 and with metamodel changes introduced in Migrate geometry metamodels from metamodels-bdd metamodels#22
- Add test for checking SHACL constraints and model processing functions
initial unit test checks Kinova robot model & a mockup JSON-LD model with Euler angles against geometry SHACL in secorolab/metamodels repo
minhnh
added a commit
to minhnh/bdd-dsl
that referenced
this pull request
Mar 5, 2025
- probability model processing was migrated in secorolab/rdf-utils#2 - geometry model processing will be migrated in secorolab/rdf-utils#4
- add func to extract Euler angles axes sequence & intrinsic/extrinsic - add func to extract angles for AnglesAlphaBetaGamma type - add func to extract `scipy.spatial.transform.Rotation` from a coordinate model, for now only handle AnglesAlphaBetaGamma - add relevant URIs for Euler angles & unit - update unit test to cover these functions
KishanSawant
approved these changes
Mar 5, 2025
vamsikalagaturu
approved these changes
Mar 6, 2025
minhnh
added a commit
to minhnh/bdd-dsl
that referenced
this pull request
Mar 6, 2025
- probability model processing was migrated in secorolab/rdf-utils#2 - geometry model processing will be migrated in secorolab/rdf-utils#4
(instead of creating a new coordinate namespace for SECORO)
argenos
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.