Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @sats-connect/core version #131

Merged
merged 16 commits into from
Jul 5, 2024
Merged

Update @sats-connect/core version #131

merged 16 commits into from
Jul 5, 2024

Conversation

aryzing
Copy link
Contributor

@aryzing aryzing commented May 29, 2024 •
edited by m-aboelenein
Loading

  • Updates sats-connect-core to latest version
  • Updates example app to include
    • getBtcBalance
    • getRunesBalance
    • getInscriptions
    • Use updated connect / permissions request

@aryzing aryzing force-pushed the eduard/update-core branch 2 times, most recently from 15bca0d to 21d9b21 Compare June 25, 2024 15:51
@aryzing aryzing marked this pull request as ready for review June 25, 2024 15:52
@aryzing aryzing requested a review from m-aboelenein June 25, 2024 15:52
@aryzing aryzing force-pushed the eduard/update-core branch 4 times, most recently from 3b30e01 to 9b4214c Compare June 27, 2024 10:47
@aryzing aryzing force-pushed the eduard/update-core branch from 9b4214c to 3a74757 Compare June 27, 2024 13:57
@netlify Netlify
Copy link

netlify bot commented Jul 1, 2024 •
edited
Loading

✅ Deploy Preview for sats-connect ready!

Name Link
🔨 Latest commit 2a4a5ba
🔍 Latest deploy log https://app.netlify.com/sites/sats-connect/deploys/6686b1aacca7010008a7732d
😎 Deploy Preview https://deploy-preview-131--sats-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

teebszet
teebszet reviewed Jul 1, 2024
View reviewed changes
example/src/App.tsx Outdated Show resolved Hide resolved
teebszet
teebszet previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@teebszet teebszet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! ⚠️ needs core version released

@teebszet teebszet removed the request for review from m-aboelenein July 1, 2024 14:07
@aryzing aryzing requested a review from teebszet July 1, 2024 14:31
@teebszet
Copy link
Member

teebszet commented Jul 1, 2024

nit: Connect2 could do with a gap and better name.. Connect (>=v2.5.0)? would we ultimately want to provide a Connect button which tries connect2 and degrades gracefully to connect1?

image

teebszet
teebszet previously approved these changes Jul 1, 2024
View reviewed changes
@aryzing
Copy link
Contributor Author

aryzing commented Jul 1, 2024

Good nit, fixed
image

@aryzing aryzing changed the title Update core Update @sats-connect/core version Jul 1, 2024
@aryzing aryzing requested review from m-aboelenein and teebszet July 3, 2024 13:20
aryzing
aryzing commented Jul 3, 2024
View reviewed changes
src/index.ts Show resolved Hide resolved
m-aboelenein
m-aboelenein reviewed Jul 3, 2024
View reviewed changes
example/src/App.tsx Outdated Show resolved Hide resolved
@aryzing aryzing requested a review from m-aboelenein July 4, 2024 08:46
@aryzing aryzing force-pushed the eduard/update-core branch from e928ace to 2a4a5ba Compare July 4, 2024 14:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Test this PR with npm i --save-exact [email protected]

@Christine-Pinto Christine-Pinto self-requested a review July 5, 2024 14:25
@aryzing aryzing merged commit 369b396 into develop Jul 5, 2024
10 checks passed
@aryzing aryzing deleted the eduard/update-core branch July 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christine-Pinto Christine-Pinto Christine-Pinto approved these changes

@teebszet teebszet Awaiting requested review from teebszet

@m-aboelenein m-aboelenein Awaiting requested review from m-aboelenein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aryzing @teebszet @Christine-Pinto @m-aboelenein