Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wallet type in sats-connect #148

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Conversation

aryzing
Copy link
Contributor

@aryzing aryzing commented Jul 9, 2024

ENG-4511

  • Updates sats-connect/core to latest version
  • Adds example to query walletType
  • Adds example for getAccounts allowing inspection of walletType returned by wallet.

⚠️ requires

simplescreenrecorder-2024-07-09_14.55.53.webm

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for sats-connect ready!

Name Link
🔨 Latest commit 6f221db
🔍 Latest deploy log https://app.netlify.com/sites/sats-connect/deploys/669673897a9b7f00083e3e4c
😎 Deploy Preview https://deploy-preview-148--sats-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aryzing aryzing requested review from m-aboelenein and teebszet and removed request for teebszet and m-aboelenein July 9, 2024 13:57
@aryzing aryzing mentioned this pull request Jul 10, 2024
@teebszet
Copy link
Member

@aryzing is this ready for review?

@aryzing
Copy link
Contributor Author

aryzing commented Jul 11, 2024

@teebszet I believe so, although have it as draft as it builds on code from PRs not yet merged so there are changes in this PR not relevant to this feature

@aryzing aryzing marked this pull request as ready for review July 16, 2024 09:38
Copy link

Test this PR with npm i --save-exact [email protected]

@aryzing aryzing merged commit 97e58dd into develop Jul 16, 2024
7 checks passed
@aryzing aryzing deleted the edu/wallet-type branch July 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants