Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4599] Tim/add send sip10 and reorganise #162

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Aug 6, 2024

context: https://linear.app/xverseapp/issue/ENG-4599/look-into-post-conditions-that-were-constructing-these-properly-tim

changes:

  • added send sip10 route
  • refactored to split into routes and use mantine UI

@teebszet teebszet requested a review from aryzing August 6, 2024 06:42
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for sats-connect ready!

Name Link
🔨 Latest commit a38c12d
🔍 Latest deploy log https://app.netlify.com/sites/sats-connect/deploys/66bc89bc8b459d00081e7310
😎 Deploy Preview https://deploy-preview-162--sats-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@teebszet
Copy link
Member Author

teebszet commented Aug 6, 2024

@aryzing I'm not sure if I have the encoding right here to send 100LEO to an address. any ideas?

I get this error on the popup:
image

Comment on lines +69 to +79
const response = await Wallet.request('stx_callContract', {
contract: form.contract,
functionName: 'transfer',
arguments: [
uintCV(+form.amount),
standardPrincipalCV(stxAddressInfo?.[0].address),
standardPrincipalCV(form.address),
noneCV(),
//form.memo ? someCV(bufferCV(Buffer.from(form.memo))) : noneCV(),
].map((arg) => cvToString(arg)),
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-aboelenein @aryzing any ideas on whether there's something causing the error here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the map, try with cvToHex()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank you, i'll try that and make a note to update the docs https://docs.xverse.app/sats-connect/stacks-methods/stx_callcontract

actually a lot of the stx docs seem to be incomplete

Copy link

Test this PR with npm i --save-exact [email protected]

Copy link
Contributor

@terencehh terencehh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested working

JanKortes212

This comment was marked as spam.

@teebszet teebszet merged commit 53e20e5 into develop Aug 20, 2024
7 checks passed
@teebszet teebszet deleted the tim/add-send-sip10-and-reorganise branch August 20, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants