mahmoud/eng-3688-detecting-the-wallet-api-bitcoin-provider #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorkirov
requested changes
Mar 1, 2024
victorkirov
reviewed
Mar 5, 2024
teebszet
reviewed
Mar 6, 2024
|
|
||
| export type Requests = BtcRequests & StxRequests; | ||
|
|
||
| export type Return<Method> = Method extends keyof Requests ? Requests[Method]['result'] : never; |
There was a problem hiding this comment.
what's the difference between this and:
Suggested change
| export type Return<Method> = Method extends keyof Requests ? Requests[Method]['result'] : never; | |
| export type Return<Method extends keyof Requests> = Requests[Method]['result']; |
There was a problem hiding this comment.
True, yours is better as you'll get a type warning directly rather than silently accepting the method name with a never result.
teebszet
reviewed
Mar 6, 2024
teebszet
reviewed
Mar 6, 2024
* Proposed typing for the result * Remove cancel state
…-bitcoin-provider
|
m-aboelenein
deleted the
mahmoud/eng-3688-detecting-the-wallet-api-bitcoin-provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.