Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etching example + cleanup #99

Merged
merged 5 commits into from
Apr 16, 2024
Merged

etching example + cleanup #99

merged 5 commits into from
Apr 16, 2024

Conversation

m-aboelenein
Copy link
Member

@m-aboelenein m-aboelenein commented Apr 15, 2024 •
edited
Loading

  • Adds an etching example to the test app
  • Export Wallet instance instead of static class
  • update sats-connect-core to the latest version (bug-fix - btc_providers array mutated on connect)

@m-aboelenein m-aboelenein self-assigned this Apr 15, 2024
emilcondrea
emilcondrea reviewed Apr 15, 2024
View reviewed changes
example/src/components/EtchRunes/index.tsx
);

const onClickEstimate = async () => {
const response = await Wallet.request('runes_estimateEtch', {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an amount & cap. Open mints without a cap are unmintable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens on the service if you submit an order with isMintable=true and no amount & cap?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will throw a 400

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be caught in the sats-connect method and would return an error result here, so maybe that's enough?

@m-aboelenein m-aboelenein changed the title etching example etching example + cleanup Apr 16, 2024
@github-actions GitHub Actions
Copy link

Test this PR with npm i --save-exact [email protected]

@m-aboelenein m-aboelenein merged commit 5efa6b3 into develop Apr 16, 2024
3 checks passed
@m-aboelenein m-aboelenein deleted the chore/add-runes-etching-example branch April 16, 2024 14:43
@m-aboelenein m-aboelenein mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilcondrea emilcondrea emilcondrea left review comments

@victorkirov victorkirov victorkirov approved these changes

Assignees

@m-aboelenein m-aboelenein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-aboelenein @victorkirov @emilcondrea