Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include only dist in published package #235

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Sep 12, 2023

🔘 PR Type

  • Build related changes

📜 Background

@fedeerbes discovered the cause of some type issues, which this hopefully solves

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • build related changes only

Impact:

  • test the consuming applications aren't missing any functions not exported

before npm publish --dry-run

image

after npm publish --dry-run

image

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@teebszet teebszet requested a review from fedeerbes September 12, 2023 02:46
@github-actions
Copy link
Contributor

Test this PR with npm i @secretkeylabs/[email protected]

@teebszet teebszet marked this pull request as draft September 15, 2023 08:23
@teebszet
Copy link
Member Author

@fedeerbes mentioned this will break a lot of our existing references from the consuming apps.

I think this repo needs a big cleanup of the import/export organisation

@teebszet
Copy link
Member Author

depends on removing all instances of internal imports like were fixed here (but on both extension and mobile:
secretkeylabs/xverse-web-extension#630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant