Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Support Keystone 3 Pro #393

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

keystoneGithub
Copy link
Collaborator

@keystoneGithub keystoneGithub commented Nov 26, 2024

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:
    Add API for integrating Keystone 3 Pro

📜 Background

This PR introduces Keystone WebUSB SDK and implements logic about wallet creating and transaction generation.

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • What has been modified, added, or removed
  • Which are breaking changes
  1. Introduce Keystone WebUSB SDK.
  2. Logic about address and transaction generation.

Impact:

  • How it improves performance, fixes bugs, adds functionality, etc.
  • Impact on downstream apps, link to issues or PRs for migration
  • What to test

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant