Fix for workflow Upload Playwright report in ci/cd (#809)

* Fix for workflow Upload Playwright report in ci/cd * updated the build-rc.yml post-comment
secretkeylabs · Dec 5, 2024 · b2d4adb · b2d4adb
1 parent bb74e6a
commit b2d4adb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/.github/workflows/build-rc.yml b/.github/workflows/build-rc.yml
@@ -50,6 +50,7 @@ jobs:
           path: ./build
           retention-days: 5
           if-no-files-found: error
+          overwrite: true
   UItest:
     needs: [build]
     name: E2E Test ${{ matrix.shardIndex }} of ${{ matrix.shardTotal }}
@@ -90,9 +91,13 @@ jobs:
         if: ${{ !cancelled() }}
         uses: actions/upload-artifact@v4
         with:
-          name: all-blob-reports
+          name: blob-report-${{ matrix.shardIndex }}-of-${{ matrix.shardTotal }}
           path: blob-report
           retention-days: 1
+          if-no-files-found: warn
+          compression-level: 6
+          overwrite: true
+          include-hidden-files: false
 
   merge-reports:
     # Merge reports after playwright-tests, even if some shards have failed but not if the job was skipped
@@ -116,8 +121,9 @@ jobs:
       - name: Download blob reports from GitHub Actions Artifacts
         uses: actions/download-artifact@v4
         with:
-          name: all-blob-reports
+          pattern: blob-report-*
           path: all-blob-reports
+          merge-multiple: true
 
       - name: Merge into HTML Report
         run: npx playwright merge-reports --reporter html ./all-blob-reports
@@ -128,6 +134,7 @@ jobs:
           name: html-report--attempt-${{ github.run_attempt }}
           path: playwright-report
           retention-days: 4
+          overwrite: true
 
   publish-rc:
     # TODO also keep the develop PR description up to date
@@ -206,7 +213,7 @@ jobs:
       - name: zip
         run: zip -rj build.zip ./build
       - name: Upload release asset
-        uses: actions/upload-release-asset@v1
+        uses: actions/upload-release-asset@v1 # TODO: use softprops/action-gh-release@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           UPLOAD_URL: ${{needs.publish-rc.outputs.upload_url}}

diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -84,7 +84,7 @@ jobs:
         if: ${{ !cancelled() }}
         uses: actions/upload-artifact@v4
         with:
-          name: all-blob-reports
+          name: blob-report-${{ matrix.shardIndex }}-of-${{ matrix.shardTotal }}
           path: blob-report
           retention-days: 1
           overwrite: true
@@ -111,8 +111,9 @@ jobs:
       - name: Download blob reports from GitHub Actions Artifacts
         uses: actions/download-artifact@v4
         with:
-          name: all-blob-reports
+          pattern: blob-report-*
           path: all-blob-reports
+          merge-multiple: true
 
       - name: Merge into HTML Report
         run: npx playwright merge-reports --reporter html ./all-blob-reports