feat: STX NFTs Tab #634
Merged
feat: STX NFTs Tab #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fetching-pagination-and-load-more-button
…-extension into imamahzafar/eng-2807-stacks-nft-tab-data-fetching-pagination-and-load-more-button
…ation-and-load-more-button' of https://github.com/secretkeylabs/xverse-web-extension into imamahzafar/eng-2807-stacks-nft-tab-data-fetching-pagination-and-load-more-button
…fetching-pagination-and-load-more-button
teebszet
reviewed
Nov 2, 2023
teebszet
reviewed
Nov 2, 2023
teebszet
reviewed
Nov 2, 2023
teebszet
reviewed
Nov 3, 2023
* Update NFT Detail UI * Use hook to get collection data * Add NFT Collection screen * Fix navigation * Remove hard coded address * Fix bns name navigation
teebszet
previously approved these changes
Nov 6, 2023
and some other bug fixes
use the react-query cache instead, and fixes bug where some nftData was not being stored
* fix: open nft page on gamma * refactor: gamma url * fix: metaData
* fix: show snackbar if nft metadata is failed to fetch * fix: snackbar styling
* feat: revamp the send nft screen * fix: back button display should rely on back history not ledger account * fix: ledger accounts should only open in new tab when not already in full screen otherwise it is annoying * fix: add the bns name resolver to send nft form * fix: opening a send-nft from ledger should open responsive screen and debounce the stx address -> bns name resolver
…uld be (#654) * chore: tweak BetterBarLoader component to receive string as width and height in order to user percentages * fix: key prop in nft collection screen * fix: hardcoded placeholder size values and replace error icon with the new one
…-stacks-nft-tab-data-fetching-pagination-and-load-more-button
* fix: detail screen UI * fix: UI alignments * fix: buttons spacing
* fix: wrong background color on transaction status screens * fix: wrong navigation routes on transaction status screen * fix: copy on inscription complete screen
* refactor: adapt to core refactor of stx collectibles * fix: add back the check for metadata before nav to nft detail screen * fix: use 24 hour staleTime for nft details to match mobile * refactor: remove unused utils function * fix: add react-is-visible to virtualise nft tab and nft collection page
|
@teebszet this pr has conflicts |
…-stacks-nft-tab-data-fetching-pagination-and-load-more-button
…fetching-pagination-and-load-more-button
|
teebszet
approved these changes
Nov 21, 2023
teebszet
deleted the
imamahzafar/eng-2807-stacks-nft-tab-data-fetching-pagination-and-load-more-button
branch
fedeerbes
pushed a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.
Issue Link: #[ENG-3140]
#[ENG-2807]
🔄 Changes
STX Collectible Dashboard screen UI updated
🖼 Screenshot / 📹 Video
NFT.mov
✅ Review checklist
Please ensure the following are true before merging: