[ENG-3327] chore: run on ci type checking and unit tests #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teebszet
commented
Nov 27, 2023
| @@ -125,7 +129,7 @@ export type SignPsbtResponseMessage = Message< | |||
| ExternalSatsMethods.signPsbtResponse, | |||
| { | |||
| signPsbtRequest: string; | |||
| signPsbtResponse: SignPsbtResponse | string; | |||
| signPsbtResponse: SignTransactionResponse | string; | |||
There was a problem hiding this comment.
teebszet
commented
Nov 27, 2023
Comment on lines
+260
to
+262
| if (!importedBtcAccounts) { | ||
| throw new Error('No accounts'); | ||
| } |
There was a problem hiding this comment.
would previously throw a "Cannot destructure Property of Undefined" error
teebszet
commented
Nov 27, 2023
Comment on lines
+2
to
+4
| import { describe, expect, test } from 'vitest'; | ||
| import { Side } from './types'; | ||
| import { selectedTokenReducer } from './useSwap'; |
There was a problem hiding this comment.
victorkirov
previously approved these changes
Nov 27, 2023
12 tasks
|
DuskaT021
approved these changes
Nov 27, 2023
|
@teebszet tested can be merged |
teebszet
added
ready for release
Release 0.24.0
and removed
ready for test
Release 0.25.0
labels
teebszet
changed the title
teebszet
pushed a commit
that referenced
this pull request
Jan 9, 2025
* [ENG-5252] Switching currency to BTC * Add btc balance view for token tile, account row, balance card * Show balance in fiat for the btc token tile * Add hovers, change interface -> type, remove unused imports * Skip switching to btc mode on BTC details screen * Skip show balance in btc on tokens pages without fiat value * Update the fiat block on Dashboard to not look like like it is interactive * Add `Total Balance BTC` copy, add `Show balance` button * Hide ellipses for the hidden balances when tx has no value * Add store migration for the `showBalanceInBtc` property * Add `BtcAmountText` component * Remove the export word * Simplify the balance view rendering logic * Remove undefined type option for the showBalanceInBtc redux property * [ENG-5436][ENG-5437][ENG-5438][ENG-5439] Add wallet backup reminder (#770) * [ENG-5436][ENG-5437][ENG-5438][ENG-5439] Add wallet backup reminder * Add `has_backed_up_wallet` property to the `AnalyticsEvents.CreateNewWallet` event * Make the backup reminder clickable and redirect to show seedphrase * Use the SetWalletBackupStatus interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
📜 Background
https://linear.app/xverseapp/issue/ENG-3327/fix-all-tsc-errors-on-web-extension
depends on secretkeylabs/xverse-core#296
🔄 Changes
fix: fix all simple type errors
chore: replaced all direct imports of xverse-core internals, to stop declaring type errors on those
chore: commented on and ignored remaining type errors on existing code, which looks complex to change the code behaviour
chore: turn on tsc --noEmit in CI checks
chore: turn off transpileOnly in webpack build config
chore: update ts-loader, webpack, and use fork-ts-checker-webpack-plugin to speed up type checking (from ~30s -> ~10s initial run)
fix: bumped xverse-core to 3.1.1 with fixes
https://github.com/secretkeylabs/xverse-core/releases/tag/v3.1.1
🖼 Screenshot / 📹 Video
Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.
✅ Review checklist
Please ensure the following are true before merging: