[ENG-3314] feat: support repeat minter #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordankzf
reviewed
Nov 28, 2023
| @@ -151,7 +154,8 @@ function ContentIcon({ type, content, contentType: inputContentType }: Props) { | |||
| {t('BRC20.TITLE')} {t(`BRC20.${brc20Details.op.toUpperCase()}`)} | |||
| </div> | |||
| <Suffix> | |||
| {brc20Details.tick} - {brc20Details.value} | |||
| {formatNumber(new BigNumber(brc20Details.value).multipliedBy(repeat).toString())}{' '} | |||
There was a problem hiding this comment.
(nit)
Can we break this down?
…t-inscriptions-extension-review-sign-broadcast-repeat
|
DuskaT021
approved these changes
Nov 30, 2023
| border-radius: 40px; | ||
| `; | ||
|
|
||
| function FeeRow({ |
There was a problem hiding this comment.
nit: we should move this component to a separate file
m-aboelenein
approved these changes
Nov 30, 2023
teebszet
deleted the
tim/eng-3314-repeat-inscriptions-extension-review-sign-broadcast-repeat
branch
This was referenced Dec 7, 2023
teebszet
added a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
📜 Background
depends on: secretkeylabs/sats-connect#50
issue: https://linear.app/xverseapp/issue/ENG-3314
🔄 Changes
feat: support new sats-connect version
Impact:
🖼 Screenshot / 📹 Video
Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.
✅ Review checklist
Please ensure the following are true before merging: