ENG-2696: Fix restore seed phrase screen scroll #700
Conversation
…-extension into jordankzf/eng-2696-seedphrase-screen-scroll
|
Fixed @DuskaT021's reported issue. Thanks! |
teebszet
dismissed
their stale review
need to check the layout css changes, as they affect all screens
| position: relative; | ||
| overflow-x: hidden; |
There was a problem hiding this comment.
I'm curious what did this solve for?
There was a problem hiding this comment.
scrnli_1_11_2024_2-24-51.PM.webm
overflow-x: hidden; removes the horizontal scrollbar here
| height: 100%; | ||
| min-height: 100vh; |
There was a problem hiding this comment.
did you check that this doesn't break the other screens which open up via options.html?
e.g. any of the collectibles screens when you click 'Open gallery' button, or the ledger send flows
There was a problem hiding this comment.
Yes, I did! Attached screenshots to a new comment.
| height: '100%', | ||
| minHeight: '100vh', |
There was a problem hiding this comment.
same question as below.
did you check that this doesn't break the other screens which open up via options.html?
e.g. any of the collectibles screens when you click 'Open gallery' button, or the ledger send flows
| width: '100vw', | ||
| backgroundColor: props.theme.colors.elevation0, | ||
| border: `1px solid ${props.theme.colors.elevation2}`, | ||
| boxShadow: '0px 8px 28px rgba(0, 0, 0, 0.35)', | ||
| overflow: 'hidden', |
There was a problem hiding this comment.
I'm curious what did this solve for?
There was a problem hiding this comment.
Seems like this can be safely removed.
|
@jordankzf even though this is a minor UI fix, when you touch the css/layout which is shared across many screens, it requires a thorough check that nothing was broken. in this case, it's a good idea to at least include screenshots or video of the affected layouts behaving as expected compared to production |
…-extension into jordankzf/eng-2696-seedphrase-screen-scroll
Ledger layout unaffected 
Collectibles layout unaffected
|
|
Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7485577823 |
(To Develop) Fix balance breakdown label for ordinals and tooltip, batch sign loader for listing
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.
Issue Link: #[issue_number]
Context Link (if applicable):
🔄 Changes
Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.
Impact:
🖼 Screenshot / 📹 Video
Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.
✅ Review checklist
Please ensure the following are true before merging: