Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Build #684

Merged
merged 8 commits into from
Nov 25, 2023
Merged

Fix Build #684

merged 8 commits into from
Nov 25, 2023

Conversation

fabianbs96
Copy link
Member

Although #673 was a major step towards modernizing our cmake build, there are still issues left, some of them being addressed by this PR

@fabianbs96 fabianbs96 self-assigned this Nov 20, 2023
@fabianbs96 fabianbs96 requested a review from MMory as a code owner November 20, 2023 17:04
MMory
MMory approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you! Now the build works again in Gentoo with system-wide installed llvm/clang.

@fabianbs96 fabianbs96 merged commit 4c04ed3 into development Nov 25, 2023
4 checks passed
@fabianbs96 fabianbs96 deleted the f-FixBuild branch November 25, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMory MMory MMory approved these changes

Assignees

@fabianbs96 fabianbs96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianbs96 @MMory