Skip the buggy models for now

Signed-off-by: noopur <[email protected]>
securefederatedai · Nov 8, 2024 · 7646a3c · 7646a3c
1 parent a60ad80
commit 7646a3c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/task_runner_e2e.yml b/.github/workflows/task_runner_e2e.yml
@@ -38,7 +38,11 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        model_name: [ "torch_cnn_mnist", "keras_cnn_mnist", "torch_cnn_histology", "tf_2dunet", "tf_cnn_histology" ]
+        # There are open issues for some of the models, so excluding them for now:
+        # 1. https://github.com/securefederatedai/openfl/issues/1126
+        # 2. https://github.com/securefederatedai/openfl/issues/1127 
+        # model_name: [ "torch_cnn_mnist", "keras_cnn_mnist", "torch_cnn_histology", "tf_2dunet", "tf_cnn_histology" ]
+        model_name: [ "torch_cnn_mnist", "keras_cnn_mnist" ]
       fail-fast: false # do not immediately fail if one of the combinations fail
     env:
       MODEL_NAME: ${{ inputs.model_name == 'all' && matrix.model_name || inputs.model_name }} # run all models if model_name is not provided else run the provided model

diff --git a/tests/openfl_e2e/test_suites/task_runner_tests.py b/tests/openfl_e2e/test_suites/task_runner_tests.py
@@ -38,7 +38,6 @@ def test_keras_cnn_mnist(fx_federation):
     assert fed_helper.verify_federation_run_completion(fx_federation, results), "Federation completion failed"
 
 
-@pytest.mark.skip(reason="Test is under development")
 @pytest.mark.torch_cnn_histology
 def test_torch_cnn_histology(fx_federation):
     """
@@ -56,7 +55,6 @@ def test_torch_cnn_histology(fx_federation):
     assert fed_helper.verify_federation_run_completion(fx_federation, results), "Federation completion failed"
 
 
-@pytest.mark.skip(reason="Test is under development")
 @pytest.mark.tf_2dunet
 def test_tf_2dunet(fx_federation):
     log.info(f"Test for tf_2dunet with fx_federation: {fx_federation}")
@@ -71,7 +69,6 @@ def test_tf_2dunet(fx_federation):
     assert fed_helper.verify_federation_run_completion(fx_federation, results), "Federation completion failed"
 
 
-@pytest.mark.skip(reason="Test is under development")
 @pytest.mark.tf_cnn_histology
 def test_tf_cnn_histology(fx_federation):
     log.info(f"Test for tf_cnn_histology with fx_federation: {fx_federation}")