Review comments addressed

Signed-off-by: noopur <[email protected]>

.github/workflows/task_runner_e2e.yml

@@ -5,6 +5,9 @@
 name: Task Runner E2E
 
 on:
+  pull_request:
+    branches: [ develop ]
+    types: [opened, synchronize, reopened, ready_for_review]
   schedule:
     - cron: '0 0 * * *' # Run every day at midnight
   workflow_dispatch:
@@ -67,19 +70,19 @@ jobs:
         pip install .
         pip install -r test-requirements.txt
 
-    - name: Add runner IP to /etc/hosts
-      id: add_runner_ip
-      run: |
-        sudo echo "127.0.0.1 aggregator" | sudo tee -a /etc/hosts
-        echo "Added runner IP to /etc/hosts"
+    # - name: Add runner IP to /etc/hosts
+    #   id: add_runner_ip
+    #   run: |
+    #     sudo echo "127.0.0.1 aggregator" | sudo tee -a /etc/hosts
+    #     echo "Added runner IP to /etc/hosts"
 
     - name: Run Task Runner E2E tests
       id: run_task_runner_tests
       run: |
         python -m pytest -s tests/end_to_end/test_suites/task_runner_tests.py -m ${{ env.MODEL_NAME }} --num_rounds $NUM_ROUNDS --num_collaborators $NUM_COLLABORATORS --model_name ${{ env.MODEL_NAME }}
         echo "Task runner end to end test run completed"
-      env:
-        NO_PROXY: localhost,127.0.0.1,aggregator
+      # env:
+      #   NO_PROXY: localhost,127.0.0.1,aggregator
 
     - name: Print test summary # Print the test summary only if the tests were run
       id: print_test_summary

tests/end_to_end/README.md

@@ -56,7 +56,5 @@ results
 ```
 
 ## Contribution
-Please ensure that you have tested your changes thoroughly before submitting a pull request.
 
-## License
-This project is licensed under [Apache License Version 2.0](LICENSE). By contributing to the project, you agree to the license and copyright terms therein and release your contribution under these terms.
+https://github.com/securefederatedai/openfl/blob/develop/CONTRIBUTING.md

tests/end_to_end/conftest.py

@@ -213,10 +213,9 @@ def fx_federation(request, pytestconfig):
 
     Note: As this is a module level fixture, thus no import is required at test level.
     """
-    log.info("Fixture for federation setup")
+    log.info("Fixture for federation setup using Task Runner API on single machine.")
     collaborators = []
-    # Default name for bare metal approach, modify as required.
-    agg_domain_name = "aggregator"
+    agg_domain_name = "localhost"
 
     # Parse the command line arguments
     args = parse_arguments()