Bump tensorboardX to allow new protobuf
#1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoparvanov
approved these changes
Aug 23, 2024
|
PKI test disabled. Tracking #1034. |
Signed-off-by: Shah, Karan <[email protected]>
MasterSkepticista
force-pushed
the
karansh1/tbx_bump
branch
from
a364f1e to
73c6074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR (permanently?) addresses protobuf version issues. OpenFL inadvertently capped
protobufto 3.x as a result oftensorboardX==2.6.protobuf3.20.x is >4y old at this point. So the plan is to get rid of this limitation.It was observed that protos in OpenFL-Security (internal) builds case were always built with the recent
protobufby respecting what setup actually asked for (i.e >3.20.x version), whiletensorboardX<=2.6forcedprotobufto be 3.x.In summary,
tensorboardX<=2.6currently dictatesprotobuf==3.xto be used. They have long lifted this requirement of protobuf version with a minor version bump from 2.6 to 2.6.2.Using
tensorboardX>=2.6allows usage of any recentprotobufversion, making it flexible for any TPT package. Aside,tensorboardXshould be deprecated in favor of PyTorch's nativetensorboardsupport. This will be addressed in a future PR.