-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added no-browser (headless) option to run jupyter notebooks on VM. #1054
added no-browser (headless) option to run jupyter notebooks on VM. #1054
Conversation
@psfoley I have a different opinion on this. @tanwarsh If the decision is to keep this command, it would be better to simply forward all keyword arguments to |
@MasterSkepticista I agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I may - I actually agree and support both of you, @MasterSkepticista and @tanwarsh 😊
My suggestion would be for a two-step approach:
- We merge this PR as an incremental improvement which is valuable in itself
- A second (future) PR removes the
fx tutorial
command group, and updates all relevant documentation, to help users migrate to thejupyter lab
native approach.
…ecurefederatedai#1054) * added no-browser option
…ecurefederatedai#1054) * added no-browser option
While running Jupyter Notebooks from a virtual machine FX start tutorial throws error
In order to access notebooks we need to run it in headless mode.
Added no browser option to start the server without browser.
Result: