[openfl-docker] Remove startup script dependency #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shah, Karan <[email protected]>
|
@psfoley Will this change affect FeTS code? If not, I'll proceed with the merge. |
tanwarsh
approved these changes
Oct 21, 2024
teoparvanov
approved these changes
Oct 21, 2024
|
I scanned FeTS code, no trace of this script (or containers) found. Will proceed to merge. |
MasterSkepticista
merged commit 87d8bf9
into
securefederatedai:develop
26 of 27 checks passed
MasterSkepticista
added a commit
to MasterSkepticista/openfl
that referenced
this pull request
Oct 22, 2024
) Signed-off-by: Shah, Karan <[email protected]>
tanwarsh
pushed a commit
to tanwarsh/openfl
that referenced
this pull request
Nov 18, 2024
) Signed-off-by: Shah, Karan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes dependency on actor script to start demo federation, for readability. No documentation changes are expected as a result.
Test(s):