Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging fix - No of rounds saved vs started #1094

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Logging fix - No of rounds saved vs started #1094

merged 1 commit into from
Oct 22, 2024

Conversation

noopurintel
Copy link
Contributor

@noopurintel noopurintel commented Oct 22, 2024 •
edited
Loading

In addition, enabling manual trigger of pytest coverage workflow.

Before - Round number r+1 is shown as "Saved" and "Started" both.
round_no_issue

After - Existing round number r is "Saved" and r+1 is "Started", which is expected.
round_no_fixed

ishaileshpant
ishaileshpant approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@ishaileshpant ishaileshpant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teoparvanov teoparvanov merged commit c9b02fe into securefederatedai:develop Oct 22, 2024
27 checks passed
@noopurintel noopurintel deleted the noopur/round-check branch December 12, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishaileshpant ishaileshpant ishaileshpant approved these changes

@tanwarsh tanwarsh tanwarsh approved these changes

@teoparvanov teoparvanov teoparvanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noopurintel @teoparvanov @tanwarsh @ishaileshpant