Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix coverity hash issue in metaflow_utils file #1106

Merged
merged 5 commits into from
Oct 28, 2024
Merged

fix coverity hash issue in metaflow_utils file #1106

merged 5 commits into from
Oct 28, 2024

Conversation

rajithkrishnegowda
Copy link
Collaborator

@rajithkrishnegowda rajithkrishnegowda commented Oct 25, 2024 •
edited
Loading

Fixing errors:

  1. 656300 Risky cryptographic hashing function
  2. 656287 Same on both sides

Coverity Error
Screenshot 2024-10-25 at 11 20 48 AM

Screenshot 2024-10-25 at 11 21 23 AM

Changed from md5 to sha256 hashing and removed repetitive variable

@rajithkrishnegowda rajithkrishnegowda force-pushed the fix-coverity-crypto-metaflow_util_file branch from 46a3f72 to c41647a Compare October 25, 2024 06:21
theakshaypant
theakshaypant reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@theakshaypant theakshaypant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested with any workflow API example?

@tanwarsh
Copy link
Collaborator

We should test this before merging.

@MasterSkepticista
Copy link
Collaborator

@rajithkrishnegowda Please add a dummy commit to trigger workflow interface CI tests.

@rahulga1 rahulga1 merged commit 632fe20 into securefederatedai:develop Oct 28, 2024
28 checks passed
@rajithkrishnegowda rajithkrishnegowda deleted the fix-coverity-crypto-metaflow_util_file branch December 12, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanwarsh tanwarsh tanwarsh approved these changes

@rahulga1 rahulga1 rahulga1 approved these changes

@nisha987 nisha987 nisha987 approved these changes

@theakshaypant theakshaypant theakshaypant approved these changes

@teoparvanov teoparvanov Awaiting requested review from teoparvanov

@ishaileshpant ishaileshpant Awaiting requested review from ishaileshpant

@MasterSkepticista MasterSkepticista Awaiting requested review from MasterSkepticista

@psfoley psfoley Awaiting requested review from psfoley

Assignees
No one assigned
Labels
workflow_interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajithkrishnegowda @tanwarsh @MasterSkepticista @theakshaypant @nisha987 @rahulga1