Fixes for flake8 linting #1117
Merged
Fixes for flake8 linting #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajithkrishnegowda
requested review from
MasterSkepticista,
teoparvanov,
theakshaypant,
nisha987,
rahulga1,
tanwarsh and
ishaileshpant
There was a problem hiding this comment.
@rajithkrishnegowda Also consider merging #1113 first. One of our former engineers opened it addressing Flake8. This PR can be incremental on changes from #1113.
tanwarsh
approved these changes
Nov 4, 2024
teoparvanov
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
I've merged #1113, as suggested by @MasterSkepticista. Please consider rebasing this PR's branch and merge the remaining deltas (if any).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and fixes the linting issues identified by flake8 to ensure that the Ubuntu (latest) pipeline runs successfully.
Fixes: Ubuntu (latest) pipeline
https://github.com/securefederatedai/openfl/actions/runs/11656210544/job/32452012070
Changes:
Tested locally